Skip to content

Fix doc building in CI #6884

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 9 commits into from
Closed

Fix doc building in CI #6884

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
f356fd8
make docs without multiprocessing
pmeier Nov 1, 2022
b2f6fe1
debug
pmeier Nov 2, 2022
09454f0
revert unrelated style changes
pmeier Nov 2, 2022
7573e84
readd video gallery
pmeier Nov 2, 2022
b33a68d
provide minimal reproduction
pmeier Nov 2, 2022
027a900
remove instead of comment
pmeier Nov 2, 2022
7f671ca
Merge branch 'main' into build-docs
pmeier Nov 3, 2022
09c9f75
Merge branch 'main' into build-docs
jdsgomes Nov 3, 2022
c85fef9
revert video api gallery
pmeier Nov 3, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions docs/Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ clean:
rm -rf $(SOURCEDIR)/auto_examples/ # sphinx-gallery
rm -rf $(SOURCEDIR)/gen_modules/ # sphinx-gallery
rm -rf $(SOURCEDIR)/generated/ # autosummary
rm -rf $(SOURCEDIR)/models/generated # autosummary
Copy link
Contributor Author

@pmeier pmeier Nov 2, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was missing


.PHONY: help Makefile docset

Expand Down
9 changes: 0 additions & 9 deletions torchvision/io/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,3 @@
from typing import Any, Dict, Iterator

import torch

from ..utils import _log_api_usage_once
Comment on lines -1 to -5
Copy link
Contributor Author

@pmeier pmeier Nov 2, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are no longer needed. flake8 didn't pick up on this since we blanket ignore F401, i.e. unused imports, in __init__.py files:

vision/setup.cfg

Lines 14 to 15 in c4c0ef9

per-file-ignores =
__init__.py: F401, F403, F405


from ._video_opt import (
_HAS_VIDEO_OPT,
_probe_video_from_file,
Expand Down Expand Up @@ -43,8 +37,6 @@
"_read_video_timestamps_from_memory",
"_probe_video_from_memory",
"_HAS_VIDEO_OPT",
"_read_video_clip_from_memory",
Copy link
Contributor Author

@pmeier pmeier Nov 2, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are no longer available.

"_read_video_meta_data",
"VideoMetaData",
"Timebase",
"ImageReadMode",
Expand All @@ -58,6 +50,5 @@
"write_file",
"write_jpeg",
"write_png",
"Video",
"VideoReader",
]