Skip to content

revert 255 -> max_value fix #6826

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 24, 2022
Merged

revert 255 -> max_value fix #6826

merged 1 commit into from
Oct 24, 2022

Conversation

@pmeier
Copy link
Contributor

@pmeier pmeier commented Oct 24, 2022 •
edited by pytorch-bot bot
Loading

See #6819 (comment) and #6819 (comment). This will fix will be re-instantiated again with a PR that fixes #6825.

cc @vfdev-5 @datumbox @bjuncek

@pmeier pmeier added module: transforms revert(ed) For reverted PRs, and PRs that revert other PRs prototype labels Oct 24, 2022
@pmeier pmeier requested a review from datumbox October 24, 2022 14:46
datumbox
datumbox approved these changes Oct 24, 2022
View reviewed changes
Copy link
Contributor

@datumbox datumbox left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

To clarify, the mitigation that @pmeier proposed on the previous PR is correct. We just decided to do this bugfix across all methods and all versions on the same PR. We expect to reland this change soon.

@pmeier pmeier merged commit 1878e86 into pytorch:main Oct 24, 2022
@pmeier pmeier deleted the revert-max-value branch October 24, 2022 17:06
facebook-github-bot pushed a commit that referenced this pull request Oct 27, 2022
@datumbox @facebook-github-bot
[fbsync] revert 255 -> max_value fix (#6826)
ba11b0b 
Reviewed By: YosuaMichael

Differential Revision: D40722909

fbshipit-source-id: 8086872b1eda8e66b7d4c10da0b284b13c657e76
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@datumbox datumbox datumbox approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla signed module: transforms prototype revert(ed) For reverted PRs, and PRs that revert other PRs

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Don't hardcode 255 unless uint8 is enforced

3 participants

@pmeier @datumbox @facebook-github-bot