upgrade flake8 #6678
Merged
upgrade flake8 #6678
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vfdev-5
approved these changes
Oct 3, 2022
NicolasHug
approved these changes
Oct 3, 2022
There was a problem hiding this comment.
CI job in question: https://app.circleci.com/pipelines/github/pytorch/vision/20764/workflows/9f8c7f23-34ef-4b66-a47c-e363601ee629/jobs/1689172
Failing job for ref: https://app.circleci.com/pipelines/github/pytorch/vision/20761/workflows/8956edb3-9cc1-482c-a34f-1b7dda56fcd5/jobs/1689015
Thanks Philip. We tend to ignore linter jobs internally so I think it shouldn't cause any issue to bump flake8 (and since the lint job is passing there shouldn't be any unexpected linting change anyway).
|
Hey @NicolasHug! You merged this PR, but no labels were added. The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py |
facebook-github-bot
pushed a commit
that referenced
this pull request
Oct 7, 2022
Reviewed By: datumbox Differential Revision: D40138737 fbshipit-source-id: 38d50acf00ce38dec7b4fb3bd40033070ef72678
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our current version
vision/.pre-commit-config.yaml
Line 22 in 1d7d92c
is quite outdated. Yesterdays release of
importlib-metadata==5.0.0breaksflake8==3.9.2since it uses a now removed functionality.Instead of upgrading
flake8, we could also pinimportlib-metadataand stick with our oldflake8version, but I see no point. LMK if you think different.