Skip to content

Conversation

@pmeier
Copy link
Contributor

@pmeier pmeier commented Sep 8, 2022

Follow-up to #6542. Resolves

The only thing left are the xfailed reference tests introduced in #6542. As explained there, these are not bugs in the kernel, but rather in the test setup specifically the expected output computation. @vfdev-5 Could you look into these?

@pmeier
Copy link
Contributor Author

pmeier commented Sep 8, 2022

Test failure is unrelated:

____________ test_eager_vs_scripted[gaussian_blur_image_tensor-50] _____________
Traceback (most recent call last):
  File "/home/runner/work/vision/vision/test/test_prototype_transforms_functional.py", line 751, in test_eager_vs_scripted
    torch.testing.assert_close(eager, scripted)
  File "/opt/hostedtoolcache/Python/3.7.13/x64/lib/python3.7/site-packages/torch/testing/_comparison.py", line 1359, in assert_close
    msg=msg,
  File "/opt/hostedtoolcache/Python/3.7.13/x64/lib/python3.7/site-packages/torch/testing/_comparison.py", line 1093, in assert_equal
    raise error_metas[0].to_error(msg)
AssertionError: Tensor-likes are not equal!

Mismatched elements: 1 / 1024 (0.1%)
Greatest absolute difference: 1 at index (2, 0, 13, 9)
Greatest relative difference: 0.011627906933426857 at index (2, 0, 13, 9)

@pmeier pmeier requested a review from vfdev-5 September 8, 2022 11:36
Copy link
Contributor

@datumbox datumbox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @pmeier. Nice clean ups.

The failing tests seems unrelated to me, I think this is known to be flaky. Might be worth fixing.

@vfdev-5 vfdev-5 merged commit 112accf into pytorch:main Sep 8, 2022
@pmeier pmeier deleted the cleanup branch September 8, 2022 14:01
facebook-github-bot pushed a commit that referenced this pull request Sep 9, 2022
Summary:
* avoid double padding parsing

* remove cloning in degenerate case

* fix affine and rotate for degenerate inputs

* fix rotate for degenerate inputs if expand=True

Reviewed By: YosuaMichael

Differential Revision: D39381968

fbshipit-source-id: d12a29970279b9d5de4f92d38aefc9cfef7b7e7f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants