Cleanup prototype kernels for degenerate inputs #6544
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #6542. Resolves
Although cloning here is a
O(1)operation since there is no data to copy, it also does nothing useful. Whether or not we clone or not, theTensor.data_ptr()stays the same and we only create another Python object.The only thing left are the xfailed reference tests introduced in #6542. As explained there, these are not bugs in the kernel, but rather in the test setup specifically the expected output computation. @vfdev-5 Could you look into these?