Proto transform cleanup #6408
Merged
Proto transform cleanup #6408
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmeier
commented
Aug 12, 2022
datumbox
reviewed
Aug 12, 2022
pmeier
commented
Aug 15, 2022
Contributor
Author
|
As discussed offline, this PR will also replace the |
Contributor
Author
|
|
datumbox
approved these changes
Aug 16, 2022
Contributor
datumbox
left a comment
datumbox
left a comment
There was a problem hiding this comment.
LGTM, thanks! Just an optional nit for your attention.
facebook-github-bot
pushed a commit
that referenced
this pull request
Aug 24, 2022
Summary: * fix TenCrop * use dispatchers for RandomPhotometricDistort * add convert_color_space dispatcher and use it in conversion transforms * fix convert_color_space naming scheme * add to_color_space method to Image feature * remove TODO from BoundingBox.to_format() * fix test * fix imports * fix passthrough * remove apply_recursively in favor of pytree * refactor BatchMultiCrop Reviewed By: datumbox Differential Revision: D38824225 fbshipit-source-id: 9f40885dd19e9ba701a02e209ab8839acca0fc76
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is cleanup for the prototype transforms. It includes the following changes that were put in individual commits for easier review:
TenCroptransform. The calls for PIL and simple tensor images were missing thevertical_flipflag.F.adjust_{brightness, saturation, contrast, hue}dispatchers inRandomPhotometricDistortrather than relying on theColorJittertransform.convert_color_spacedispatcher and use it in theConvertColorSpaceas well as in the deprecatedGrayscaleandRandomGrayScaletransforms.