Added ETH3D stereo dataset #6349
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NicolasHug
approved these changes
Aug 3, 2022
Member
NicolasHug
left a comment
NicolasHug
left a comment
There was a problem hiding this comment.
Thanks @TeodorPoncu , minor comments but LGTM anyway
| disparity_map = np.abs(disparity_map) # ensure that the disparity is positive | ||
| mask_path = Path(file_path).parent / "mask0nocc.png" | ||
| valid_mask = Image.open(mask_path) | ||
| valid_mask = np.asarray(valid_mask).astype(np.bool_) |
Member
There was a problem hiding this comment.
I was surprised by the us of np.bool_ and looking at numpy's warning, I think this should just be the buildin bool https://numpy.org/devdocs/release/1.20.0-notes.html#using-the-aliases-of-builtin-types-like-np-int-is-deprecated
test/test_datasets.py
Outdated
Comment on lines
2895
to
2897
| assert dataset._images and len(dataset._images) == len( | ||
| dataset._disparities | ||
| ), "Training images do not match with training disparities" |
Member
There was a problem hiding this comment.
Curious why we need this assertion. Isn't it taken care of in the shape_test_... call below?
Contributor
Author
There was a problem hiding this comment.
That assertion is unnecessary indeed! Thanks!
facebook-github-bot
pushed a commit
that referenced
this pull request
Aug 25, 2022
Summary: * Added ETH3D stereo dataset * Small doc-reformating * Removed assertions with no use, changed np conversion * Added ETH3D stereo dataset * Removed assertions with no use, changed np conversion * rebased on main * Revert "Removed assertions with no use, changed np conversion" This reverts commit 1478a8c. * Update to np.bool instead of np.bool_ * lint and mypy nit fix * test nit Reviewed By: datumbox Differential Revision: D39013683 fbshipit-source-id: adf03910e184c63363c5398c171ac668e1b8b3a9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a continuation of the PR split (#6311, #6269) which contains the ETH3D low-res two-view dataset.