Add Sintel Stereo dataset #6348
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NicolasHug
reviewed
Aug 3, 2022
Member
NicolasHug
left a comment
NicolasHug
left a comment
There was a problem hiding this comment.
Thanks @TeodorPoncu , Some minor comments but LGTM
|
|
||
|
|
||
| class SintelStereo(StereoMatchingDataset): | ||
| """ "Sintel `Stereo Dataset <http://sintel.is.tue.mpg.de/stereo>`_. |
Member
There was a problem hiding this comment.
Suggested change
| """ "Sintel `Stereo Dataset <http://sintel.is.tue.mpg.de/stereo>`_. | |
| """Sintel `Stereo Dataset <http://sintel.is.tue.mpg.de/stereo>`_. |
| Args: | ||
| root (string): Root directory where Sintel Stereo is located. | ||
| pass_name (string): The name of the pass to use, either "final" or "clean". |
Member
There was a problem hiding this comment.
Suggested change
| pass_name (string): The name of the pass to use, either "final" or "clean". | |
| pass_name (string): The name of the pass to use, either "final", "clean", or "both". |
test/test_datasets.py
Outdated
| os.makedirs(split_dir, exist_ok=True) | ||
|
|
||
| # a single setting, since there are no splits | ||
| num_examples = {"final": 2, "clean": 2} |
Member
There was a problem hiding this comment.
Just to make sure the logic is picked up on
Suggested change
| num_examples = {"final": 2, "clean": 2} | |
| num_examples = {"final": 2, "clean": 3} |
| # reshape into (C, H, W) format | ||
| disparity_map = np.transpose(disparity_map, (2, 0, 1)) | ||
| # find the appropiate file paths | ||
| occlued_mask_path, out_of_frame_mask_path = self._get_oclussion_mask_paths(file_path) |
Member
There was a problem hiding this comment.
Nit, typo
Suggested change
| occlued_mask_path, out_of_frame_mask_path = self._get_oclussion_mask_paths(file_path) | |
| occluded_mask_path, out_of_frame_mask_path = self._get_occlussion_mask_paths(file_path) |
…h/vision into add-sintel-stereo-dataset
facebook-github-bot
pushed a commit
that referenced
this pull request
Aug 24, 2022
Summary: * added SceneFLow variant datasets * Changed split name to variant name * removed trailing commented code line * Added Sintel Stereo dataset * small refactor in tests * Fixed doc formatting. * candidate fix for FileNotFound on windows test * Adressing comments * Added Sintel Stereo dataset * small refactor in tests * Fixed doc formatting. * candidate fix for FileNotFound on windows test * Adressing comments * rebased on main * lint fix Reviewed By: datumbox Differential Revision: D38824235 fbshipit-source-id: 957fcfa5182182de47ba9f99b99a1b5712b2c754
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a continuation of the PR split (#6311, #6269) which contains the Sintel Stereo training dataset.