Skip to content

Add build-system requirements #6230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 1, 2022
Merged

Add build-system requirements #6230

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,3 +12,7 @@ target-version = ["py37"]
excludes = [
"gallery",
]

[build-system]

requires = ["setuptools", "torch", "wheel"]
Copy link
Contributor

@pmeier pmeier Jul 3, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding torch as a requirement here does only somewhat solve this:

  1. pip will create a separate virtual env for these requirements, which means it will pull torch from PyPI. That means you will get a CPU version for macOS and Windows and an outdated CUDA version (10.2 IIRC) for Linux.
  2. We only have the stable binaries up on PyPI, but in general we depend on the current nightly.

Thus, even with this set, users could have problems building from source.

I don't have a solution for this. Just raising awareness.