Skip to content

Conversation

@vfdev-5
Copy link
Contributor

@vfdev-5 vfdev-5 commented May 27, 2022

Related to #5782

Description:

  • Added missing tests for other padding modes: "edge", "reflect", "symmetric"

Copy link
Contributor

@pmeier pmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor comments inline.

Copy link
Contributor

@datumbox datumbox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@vfdev-5 vfdev-5 merged commit fa37d9b into pytorch:main May 30, 2022
@vfdev-5 vfdev-5 deleted the proto-mask-pad-tests branch May 30, 2022 07:40
facebook-github-bot pushed a commit that referenced this pull request Jun 1, 2022
Summary:
* Added tests for other padding modes

* Fixed expected mask dtype

* Applied comments from review

Reviewed By: NicolasHug

Differential Revision: D36760913

fbshipit-source-id: ddb12deacb1f6215538ea37e816df670c7b1cb2e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants