expand prototype test matrix to different Python versions #6065
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
After some offline discussion with @NicolasHug, we decided to only follow up on this after the release to avoid for the CI going red for something that does not need to be fixed before the release. |
pmeier
commented
May 23, 2022
|
@NicolasHug apart from the flaky open file handle warning, expanding the CI matrix also turned up warnings that #5219 tried to solve. I've added fixes for |
Yes please! |
|
See #6076. |
This reverts commit e0734cd.
…removed (pytorch#6059)" This reverts commit 49496c4.
This reverts commit cb8b43d.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This expands the prototype test matrix to test all Python versions on Linux. This should give us some extra safety to catch stuff like #5801 and https://github.com/pytorch/data/runs/6500848588#step:9:1977, which are not visible on Python 3.7.
Since GitHub actions is free for OSS projects, this does not add any costs.