Skip to content

Indicate Celeba download parameter is deprecated and will be removed #6059

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 23, 2022
Merged

Indicate Celeba download parameter is deprecated and will be removed #6059

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
6dfe62a
Indicate download parameter is deprecated and will be removed
NicolasHug May 20, 2022
fa11eab
change default to None and raise warning if user isnt using default
NicolasHug May 20, 2022
dac7f46
aonfajoajgfnjaognojag
NicolasHug May 20, 2022
8d2e8f0
Merge branch 'main' into lafdjnaldjfnljafnajdf
NicolasHug May 23, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 16 additions & 4 deletions torchvision/datasets/celeba.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import csv
import os
import warnings
from collections import namedtuple
from typing import Any, Callable, List, Optional, Union, Tuple

Expand Down Expand Up @@ -35,11 +36,12 @@ class CelebA(VisionDataset):
and returns a transformed version. E.g, ``transforms.PILToTensor``
target_transform (callable, optional): A function/transform that takes in the
target and transforms it.
download (bool, optional): Unsupported.
download (bool, optional): Deprecated.

.. warning::

Downloading CelebA is not supported anymore as of 0.13. See
Downloading CelebA is not supported anymore as of 0.13 and this
parameter will be removed in 0.15. See
`this issue <https://github.com/pytorch/vision/issues/5705>`__
for more details.
Please download the files from
Expand Down Expand Up @@ -71,7 +73,7 @@ def __init__(
target_type: Union[List[str], str] = "attr",
transform: Optional[Callable] = None,
target_transform: Optional[Callable] = None,
download: bool = False,
download: bool = None,
) -> None:
super().__init__(root, transform=transform, target_transform=target_transform)
self.split = split
Expand All @@ -83,6 +85,15 @@ def __init__(
if not self.target_type and self.target_transform is not None:
raise RuntimeError("target_transform is specified but target_type is empty")

if download is not None:
warnings.warn(
"Downloading CelebA is not supported anymore as of 0.13, and the "
"download parameter will be removed in 0.15. See "
"https://github.com/pytorch/vision/issues/5705 for more details. "
"Please download the files from "
"https://mmlab.ie.cuhk.edu.hk/projects/CelebA.html and extract them "
"in ``root/celeba``."
)
if download:
self.download()

Expand Down Expand Up @@ -154,7 +165,8 @@ def download(self) -> None:
return

raise ValueError(
"Downloading CelebA is not supported anymore as of 0.13. See "
"Downloading CelebA is not supported anymore as of 0.13, and the "
"download parameter will be removed in 0.15. See "
"https://github.com/pytorch/vision/issues/5705 for more details. "
"Please download the files from "
"https://mmlab.ie.cuhk.edu.hk/projects/CelebA.html and extract them "
Expand Down