Skip to content

Indicate which weights correspond to pretrained=True in docs #5993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Indicate which weights correspond to pretrained=True in docs #5993

wants to merge 1 commit into from

Conversation

@NicolasHug
Copy link
Member

@NicolasHug NicolasHug commented May 11, 2022

As per @datumbox 's offline discussion, pretrained=True is equivalent to the V1 weights. This PR adds this information in the docs on all V1 weights.

image

datumbox
datumbox previously approved these changes May 11, 2022
View reviewed changes
Copy link
Contributor

@datumbox datumbox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, great idea.

@datumbox datumbox dismissed their stale review May 11, 2022 15:37

corner-cases

@datumbox
Copy link
Contributor

datumbox commented May 11, 2022

As discussed offline with @NicolasHug, there a few corner-cases such as IMAGENET1K_SWAG_E2E_V1 and IMAGENET1K_SWAG_LINEAR_V1 for which this approach won't work. I agree this feature is worth considering but not 100% sure how we can offer it. The easiest, none hacky way I can think of is to keep a mapping hidden somehwere until the deprecation takes place.

@NicolasHug NicolasHug mentioned this pull request May 23, 2022
Closed
9 tasks
@NicolasHug
Copy link
Member Author

NicolasHug commented Jul 22, 2022

The easiest, none hacky way I can think of is to keep a mapping hidden somehwere until the deprecation takes place.

I agree. Not sure when this will be available, so I'll close this PR for now. But I think it would be valuable info to document, so let's just keep it in the back of our mind

@NicolasHug NicolasHug closed this Jul 22, 2022
@datumbox datumbox mentioned this pull request Jul 29, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@datumbox datumbox datumbox left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla signed enhancement module: documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@NicolasHug @datumbox @facebook-github-bot