Expand prototype functional kernel scriptability tests #5496
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
💊 CI failures summary and remediationsAs of commit 347ed61 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
pmeier
commented
Feb 28, 2022
Comment on lines
207
to
217
| if not name.startswith("_") | ||
| and callable(kernel) | ||
| and any(feature_type in name for feature_type in {"image", "segmentation_mask", "bounding_box", "label"}) | ||
| and "pil" not in name | ||
| and ( | ||
| name | ||
| not in { | ||
| "get_image_size", | ||
| "get_image_num_channels", | ||
| } | ||
| ) |
Contributor
Author
There was a problem hiding this comment.
This is only temporary. If we have full coverage for eager vs scripted tests we can simply reuse this instead of this abomination. Still, I've checked manually and for now this covers all kernels that we want to test and should be somewhat robust for future cases.
datumbox
reviewed
Feb 28, 2022
facebook-github-bot
pushed a commit
that referenced
this pull request
Mar 5, 2022
Summary: * expand prototype functional scriptability tests * remove obsolete skips Reviewed By: datumbox Differential Revision: D34579503 fbshipit-source-id: 9425d301e5ec938bfc80494900224517815d22fb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While eager vs scripted tests require a case by case treatment due to varying inputs, just checking if something is scriptable can be achieved outside of that "framework".