Fix handle_legacy_interface when passing strings

[NicolasHug]

Hopefully fixes #5058. This does remove the warning but @pmeier please double check that this doesn't have undesired side effect!

cc @bjuncek

[facebook-github-bot]

💊 CI failures summary and remediations

As of commit 7ff78b1 (more details on the Dr. CI page):

---

💚 💚 Looks good so far! There are no failures yet. 💚 💚

---

This comment was automatically generated by Dr. CI (expand for details).

Please report bugs/suggestions to the (internal) Dr. CI Users group.

Click here to manually regenerate this comment.

[pmeier]

That might conflict with

vision/torchvision/prototype/models/detection/keypoint_rcnn.py

Lines 57 to 66 in 65438e9

	@handle_legacy_interface(
	weights=(
	"pretrained",
	lambda kwargs: KeypointRCNN_ResNet50_FPN_Weights.Coco_Legacy
	if kwargs["pretrained"] == "legacy"
	else KeypointRCNN_ResNet50_FPN_Weights.Coco_V1,
	),
	weights_backbone=("pretrained_backbone", ResNet50_Weights.ImageNet1K_V1),
	)
	def keypointrcnn_resnet50_fpn(

Could you check if

models.detection.keypointrcnn_resnet50_fpn("legacy")

and

models.detection.keypointrcnn_resnet50_fpn(pretrained="legacy")

works as expected?

[NicolasHug]

Good catch, thanks. Since this seems to be the only case where pretrained can be a string, I hardcoded it in the check.

Now both of these raise a warning (instead of failing before the last commit)

keypointrcnn_resnet50_fpn("legacy")
keypointrcnn_resnet50_fpn(pretrained="legacy")

[pmeier]

LGTM, thanks @NicolasHug!

[github-actions]

Hey @NicolasHug!

You merged this PR, but no labels were added. The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py