Add multi-type support on get_weight()
#4967
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💊 CI failures summary and remediationsAs of commit 4b1f7c2 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
datumbox
force-pushed
the
prototype/multitype_get_weight
branch
from
9a112e8 to
d03a0ee
Compare
datumbox
force-pushed
the
prototype/multitype_get_weight
branch
from
d03a0ee to
7e5ccbf
Compare
prabhat00155
approved these changes
Nov 21, 2021
6 tasks
facebook-github-bot
pushed a commit
that referenced
this pull request
Nov 30, 2021
Summary: * Add multi-type support on get_weight. * Fix bug on method call. * Adding logging suffix for QAT. Reviewed By: NicolasHug Differential Revision: D32694314 fbshipit-source-id: 4631f32d6138610ec8a0eec97c6c87ad4d4c87e8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extend the
get_weight()to handle properly model builders with multiple acceptable weight enums. This is useful for quantization.cc @datumbox @bjuncek