don't close file handles in protoype dataset tests #4963
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
💊 CI failures summary and remediationsAs of commit e7ac1f3 (more details on the Dr. CI page): 💚 💚 Looks good so far! There are no failures yet. 💚 💚 This comment was automatically generated by Dr. CI (expand for details).Please report bugs/suggestions to the (internal) Dr. CI Users group. |
facebook-github-bot
pushed a commit
that referenced
this pull request
Nov 30, 2021
Summary: * don't close file handles in protoype dataset tests * remove file closing from decoder Reviewed By: NicolasHug Differential Revision: D32694300 fbshipit-source-id: bf16b5a95736c6ef526230af1fd596f36ff18751 Co-authored-by: Francisco Massa <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I thought that would be a good idea when I added it in #4863. Turns out, this only works under the assumption that every file is present in exactly one sample. Optical flow datasets like Sintel violate that assumption, which leads to test failures although the dataset works fine.
torchdatahas some internal functionality to close files when a datapipe is exhausted. Better to just rely on that to avoid issues like this in the future.cc @pmeier @bjuncek