Skip to content

use better default decoder for prototype dataset tests #4863

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 12, 2021
Merged

use better default decoder for prototype dataset tests #4863

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
41c7f57
use better default decoder for prototype dataset tests
pmeier Nov 4, 2021
995322e
Merge branch 'main' into test-decoding
pmeier Nov 12, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion test/builtin_dataset_mocks.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,10 +100,16 @@ def _get(self, dataset, config):
return mock_resources, mock_info

def _decoder(self, dataset_type):
def to_bytes(file):
try:
return file.read()
finally:
file.close()

if dataset_type == datasets.utils.DatasetType.RAW:
return datasets.decoder.raw
else:
return lambda file: file.close()
return to_bytes

def load(
self, name: str, decoder=DEFAULT_TEST_DECODER, split="train", **options: Any
Expand Down