replace np.frombuffer with torch.frombuffer in MNIST prototype #4651
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmeier
commented
Oct 19, 2021
Comment on lines
+70
to
+72
| # The MNIST format uses the big endian byte order. If the system uses little endian byte order by default, | ||
| # we need to reverse the bytes before we can read them with torch.frombuffer(). | ||
| needs_byte_reversal = sys.byteorder == "little" and num_bytes_per_value > 1 |
datumbox
reviewed
Oct 19, 2021
ysiraichi
reviewed
Oct 19, 2021
fmassa
approved these changes
Oct 26, 2021
facebook-github-bot
pushed a commit
that referenced
this pull request
Oct 27, 2021
…pe (#4651) Summary: * replace np.frombuffer with torch.frombuffer in MNIST prototype * cleanup * appease mypy * more cleanup * clarify inplace offset * fix num bytes for floating point data Reviewed By: NicolasHug Differential Revision: D31957855 fbshipit-source-id: 0b61f117b74db87c249ff83d9a9a9ed30896130a
cyyever
pushed a commit
to cyyever/vision
that referenced
this pull request
Nov 16, 2021
…ch#4651) * replace np.frombuffer with torch.frombuffer in MNIST prototype * cleanup * appease mypy * more cleanup * clarify inplace offset * fix num bytes for floating point data
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Complement to #4598.
cc @pmeier @bjuncek