Add typing annotations to detection/image_list #4602
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
14 tasks
prabhat00155
approved these changes
Oct 12, 2021
Contributor
prabhat00155
left a comment
prabhat00155
left a comment
There was a problem hiding this comment.
Thanks @oke-aditya! Minor comment, otherwise looks good.
Contributor
Author
|
Done :) |
|
Hey @prabhat00155! You merged this PR, but no labels were added. |
facebook-github-bot
pushed a commit
that referenced
this pull request
Oct 14, 2021
Summary: * Add typing for imagelist, move params to docstring * Add docs Reviewed By: fmassa Differential Revision: D31649963 fbshipit-source-id: c70e62901fb02942f2bc2949202ddeb43a2a7410
mszhanyi
pushed a commit
to mszhanyi/vision
that referenced
this pull request
Oct 19, 2021
* Add typing for imagelist, move params to docstring * Add docs
cyyever
pushed a commit
to cyyever/vision
that referenced
this pull request
Nov 16, 2021
* Add typing for imagelist, move params to docstring * Add docs
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Helps #4582
cc @datumbox