Switch from np.frombuffer to torch.frombuffer #4578
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
datumbox
reviewed
Oct 8, 2021
There was a problem hiding this comment.
@lc0 Thanks a lot for the quick PR. Overall it looks great. I believe you removed the use of numpy frombuffer from all places.
@pmeier there is one more below, do you think it's worth changing it?
vision/torchvision/datasets/mnist.py
Line 516 in a485b8c
I think we can also refactor that use-case. I was just not sure if we loose readability by doing so or no. So what do you think @pmeier |
prabhat00155
approved these changes
Oct 8, 2021
|
Hey @prabhat00155! You merged this PR, but no labels were added. |
Yes, I think so. I'll send a PR. |
facebook-github-bot
pushed a commit
that referenced
this pull request
Oct 14, 2021
Summary: Co-authored-by: Prabhat Roy <[email protected]> Reviewed By: fmassa Differential Revision: D31649965 fbshipit-source-id: bac1178be3902694af3b2b3d195e0abfe0d640e5
mszhanyi
pushed a commit
to mszhanyi/vision
that referenced
this pull request
Oct 19, 2021
Co-authored-by: Prabhat Roy <[email protected]>
cyyever
pushed a commit
to cyyever/vision
that referenced
this pull request
Nov 16, 2021
Co-authored-by: Prabhat Roy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Accordingly to pytorch/pytorch#59077 this PR migrates from np.frombuffer to pytorch.frombuffer and closes #4552
cc @pmeier