fix import order for torchvision.prototype.datasets #4538
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NicolasHug
reviewed
Oct 5, 2021
|
|
||
| # Load this last, since some parts depend on the above being loaded first | ||
| from ._api import register, _list as list, info, load | ||
| from ._api import register, _list as list, info, load # usort: skip |
Member
There was a problem hiding this comment.
Just curious, what's the reason we need to load these after _home?
Contributor
Author
There was a problem hiding this comment.
To avoid cyclic imports. Importing anything from _api here will try to import home:
facebook-github-bot
pushed a commit
that referenced
this pull request
Oct 7, 2021
Reviewed By: kazhang Differential Revision: D31391272 fbshipit-source-id: 093631390dcace3d1e3e21d264f68405399b0743
mszhanyi
pushed a commit
to mszhanyi/vision
that referenced
this pull request
Oct 19, 2021
cyyever
pushed a commit
to cyyever/vision
that referenced
this pull request
Nov 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was broken by #4384, but not detected since we don't have tests for the prototype functionality yet.