FIX CMAKE_WINDOWS_GPU workflow #4419
Merged
+46
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
mszhanyi
changed the title
mszhanyi
changed the title
malfet
approved these changes
Sep 17, 2021
Contributor
malfet
left a comment
malfet
left a comment
There was a problem hiding this comment.
I don't understand why cuda_install.bat needs to be changed now, but will delete it in followup PR
Contributor
Author
@malfet |
facebook-github-bot
pushed a commit
that referenced
this pull request
Sep 30, 2021
Summary: * add cuda envs * packaging doesn't need cuda env now * fix cmake_windows_gpu * minor fix * rename suffix * minor change * update vs integration Reviewed By: datumbox Differential Revision: D31268038 fbshipit-source-id: 90fd5c04da06fb219df4af5ca10cea8be043d83e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4440
one step of enable windows cuda tests.
Add environment variables for installed cuda binaries.
update VS integration directory.
It's extracted from #4435.
@NicolasHug, could you take a loot at those failed test cases in #4435 . Could I disable them when I submit the next PRs.
@malfet @NicolasHug
What's the PR's impact?
In fact, the current CMAKE_WINDOWS_GPU result is incorrect.
For example.
Though #4412 passed all tests, From CMAKE_WINDOWS_GPU log.
https://circleci.com/api/v1.1/project/github/pytorch/vision/796642/output/103/0?file=true&allocation-id=6143fcff7205b60efcdd62e4-0-build%2F6F92D232
We could find it is compiled with 10.1 runtime not the specified 10.2 runtime
cc @seemethere