Make torch version check numeric #4285
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jithunnair-amd
force-pushed
the
numeric_torch_version_check
branch
from
411b1f8 to
106b293
Compare
datumbox
approved these changes
Aug 17, 2021
Contributor
datumbox
left a comment
datumbox
left a comment
There was a problem hiding this comment.
LGTM, thanks! Will merge once the CI completes.
facebook-github-bot
pushed a commit
that referenced
this pull request
Aug 20, 2021
Summary: Co-authored-by: Vasilis Vryniotis <[email protected]> Reviewed By: NicolasHug Differential Revision: D30417204 fbshipit-source-id: 17ba279a691378c2f6ad9968bd7b9ece823173a6
fmassa
reviewed
Aug 20, 2021
Comment on lines
-150
to
+152
| if torch.__version__ >= '1.5': | ||
| TORCH_MAJOR = int(torch.__version__.split('.')[0]) | ||
| TORCH_MINOR = int(torch.__version__.split('.')[1]) | ||
| if TORCH_MAJOR > 1 or (TORCH_MAJOR == 1 and TORCH_MINOR >= 5): |
Member
There was a problem hiding this comment.
Should we be using the newly introduced TorchVersion instead?
Contributor
There was a problem hiding this comment.
If we want to use the new torch.__version__ as a TorchVersion object , then just reverting this pr will do the job.
Or can I create a new pr for just one line?
Member
There was a problem hiding this comment.
Or can I create a new pr for just one line?
Yup :)
jithunnair-amd
added a commit
to ROCm/vision
that referenced
this pull request
Aug 23, 2021
Co-authored-by: Vasilis Vryniotis <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
String comparison messes up in cases such as
torch.__version__ = 1.10.blah