Ignore direnv files #4200
Merged
Ignore direnv files #4200
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Thanks for the PR @garymm Would it be feasible for you to rely on a custom set of gitignore rules instead? Something like https://stackoverflow.com/questions/6117109/is-it-possible-to-have-a-custom-gitignore-read-only-access |
Contributor
Author
|
Seems like widely used tools are already included in .gitignore (e.g. vscode files). |
Member
|
vscode is the default at fb so that's why it's here. But yeah there is stuff like .idea/ .orig and *.venv that are more user specific (and that shouldn't be here IMHO, but OK, let's merge) |
|
Hey @NicolasHug! You merged this PR, but no labels were added. |
Member
|
tagging it as CI for lack of better tag |
Contributor
Author
|
Thanks! |
facebook-github-bot
pushed a commit
that referenced
this pull request
Jul 27, 2021
Reviewed By: fmassa Differential Revision: D29932705 fbshipit-source-id: fd31b99a6dbe5b32becf9c6440762280b5e6545f
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://direnv.net/.