Add support for files with periods in name #4099
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmeier
reviewed
Jun 23, 2021
Contributor
pmeier
left a comment
pmeier
left a comment
There was a problem hiding this comment.
Hey @adamjstewart, thanks for the PR! I have two comments inline.
adamjstewart
force-pushed
the
features/suffixes
branch
from
c32d5ac to
1e5252c
Compare
pmeier
approved these changes
Jun 23, 2021
Contributor
pmeier
left a comment
pmeier
left a comment
There was a problem hiding this comment.
LGTM, thanks @adamjstewart!
NicolasHug
approved these changes
Jun 23, 2021
Member
NicolasHug
left a comment
NicolasHug
left a comment
There was a problem hiding this comment.
Thanks @adamjstewart and @pmeier for the review!
facebook-github-bot
pushed a commit
that referenced
this pull request
Jun 25, 2021
Reviewed By: NicolasHug Differential Revision: D29369896 fbshipit-source-id: c3de547efcfef93bcd66bdeb249178cfe39538e7
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, files like
foo.bar.ziporfoo.bar.tar.gzcould not be extracted. This PR adds support for files with periods in their name.Examples of datasets like this include:
This is a follow-up to #3443
@pmeier @calebrob6