-
Notifications
You must be signed in to change notification settings - Fork 7.2k
Update CI jobs xcode/macOS version to match PyTorch core #3778
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Our CI is broken, so to confirm that this change fixes at least some of the issues, I did some digging. On latest master, the following macOS jobs fail:
in this PR all the above methods seems to run fine. Let's wait until all the CI tests complete to confirm and then merge.
Edit: The tests still fail but that's because of an issue on a unit-test. It's unrelated and we'll ping the author of the PR who broke it to investigate.
|
@fmassa @bjuncek Now that the CI can run properly, it uncovered an issue with the following unit-test: |
|
Thanks @mthrok! |
) Summary: xcode Version 9 is no longer supported by Apple. https://developer.apple.com/support/xcode/ Updating xcode to 12.0, which also updates the macOS to 10.15. See https://circleci.com/docs/2.0/testing-ios/#supported-xcode-versions Reviewed By: datumbox Differential Revision: D28473338 fbshipit-source-id: 786d7d199511958b1da07ba1ddffbf1d4810cf6c
xcode Version 9 is no longer supported by Apple. https://developer.apple.com/support/xcode/
Updating it to
xcode: 12.0
macOS: 10.15
See https://circleci.com/docs/2.0/testing-ios/#supported-xcode-versions
See also: pytorch/audio#1485