add tests for Kinetics400 #3457
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmeier
commented
Feb 25, 2021
Comment on lines
+973
to
+974
| def test_not_found_or_corrupted(self): | ||
| self.skipTest("Dataset currently does not handle the case of no found videos.") |
Contributor
Author
There was a problem hiding this comment.
This can be removed after #2903 is fixed.
|
maybe related: #3273 |
Contributor
Author
|
@vadimkantorov That would be #3453 😉 |
Codecov Report
@@ Coverage Diff @@
## master #3457 +/- ##
==========================================
+ Coverage 75.96% 76.26% +0.29%
==========================================
Files 105 105
Lines 9707 9697 -10
Branches 1556 1556
==========================================
+ Hits 7374 7395 +21
+ Misses 1852 1822 -30
+ Partials 481 480 -1
Continue to review full report at Codecov.
|
Closed
fmassa
approved these changes
Mar 1, 2021
Comment on lines
+1038
to
+1042
| def test_not_found_or_corrupted(self): | ||
| # LSUN does not raise built-in exception, but a custom one. It is expressive enough to not 'cast' it to | ||
| # RuntimeError or FileNotFoundError that are normally checked by this test. | ||
| with self.assertRaises(datasets_utils.lazy_importer.lmdb.Error): | ||
| super().test_not_found_or_corrupted() |
Member
There was a problem hiding this comment.
nit: this is an unrelated fix and would have been better fit for a separate PR
facebook-github-bot
pushed a commit
that referenced
this pull request
Mar 4, 2021
Summary: * add tests for Kinetics400 * use create_random_string() Reviewed By: fmassa Differential Revision: D26756281 fbshipit-source-id: a4fb2dde283a45cc8675db343d765881ceaba91d Co-authored-by: Philip Meier <[email protected]> Co-authored-by: Francisco Massa <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.