add tests for MNIST and variants #3423
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Member
|
There are some conflicts now, can you look into fixing them? |
pmeier
commented
Mar 16, 2021
pmeier
requested review from
NicolasHug and
fmassa
and removed request for
fmassa
Contributor
Author
|
Blocked by #3578. |
NicolasHug
approved these changes
Mar 22, 2021
Member
NicolasHug
left a comment
NicolasHug
left a comment
There was a problem hiding this comment.
Thanks @pmeier , some minor comment but LGTM anyway!
fmassa
reviewed
Mar 24, 2021
Member
fmassa
left a comment
fmassa
left a comment
There was a problem hiding this comment.
Looks great to me, thanks!
Can you just keep the mnist_root for now to err on the safe side?
facebook-github-bot
pushed a commit
that referenced
this pull request
Apr 1, 2021
Summary: * add tests for MNIST and variants * remove old tests and fakedata generation * fix default config detection for if dataset has variable keywords * use split="mnist" as default for EMNIST * fix QMNIST tests * lint * fix special kwargs detection * Revert "use split="mnist" as default for EMNIST" This reverts commit 62c9b23. * fix tests * fix QMNIST test case name * remove dead code from test * Revert "remove old tests and fakedata generation" This reverts commit a285b97. * remove old tests * readd removed import Reviewed By: fmassa Differential Revision: D27433912 fbshipit-source-id: 2af75d5531880266286cd2a4045fcdee594da548
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds tests for
[EQ]MNISTand supersedes the old tests for(Fashion|K)?MNIST.Blocked by #3420.