Skip to content

Switching to Pytorch's clang-formatter. #2872

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 22, 2020
Merged

Switching to Pytorch's clang-formatter. #2872

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e82fb1b
Switching to Pytorch's clang-formatter.
datumbox Oct 22, 2020
46a08e1
Replacing binary.
datumbox Oct 22, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,9 +127,10 @@ jobs:
- checkout
- run:
command: |
sudo apt-get update -y
sudo apt-get install -y clang-format
./travis-scripts/run-clang-format/run-clang-format.py -r torchvision/csrc
curl https://oss-clang-format.s3.us-east-2.amazonaws.com/linux64/clang-format-linux64 -o clang-format
chmod +x clang-format
sudo mv clang-format /opt/clang-format
./travis-scripts/run-clang-format/run-clang-format.py -r torchvision/csrc --clang-format-executable /opt/clang-format

binary_linux_wheel:
<<: *binary_common
Expand Down
7 changes: 4 additions & 3 deletions .circleci/config.yml.in
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,9 +127,10 @@ jobs:
- checkout
- run:
command: |
sudo apt-get update -y
sudo apt-get install -y clang-format
./travis-scripts/run-clang-format/run-clang-format.py -r torchvision/csrc
curl https://oss-clang-format.s3.us-east-2.amazonaws.com/linux64/clang-format-linux64 -o clang-format
chmod +x clang-format
sudo mv clang-format /opt/clang-format
Copy link
Member

@fmassa fmassa Oct 22, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: do we need to move this to /opt/clang-format if we can specify a --clang-format-executable in the script?

Copy link
Contributor Author

@datumbox datumbox Oct 22, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not really necessary. I did not want to leave a binary in the root of the project. Can make a change if you want.

Copy link
Member

@fmassa fmassa Oct 22, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No worries, it was just for my information.

./travis-scripts/run-clang-format/run-clang-format.py -r torchvision/csrc --clang-format-executable /opt/clang-format

binary_linux_wheel:
<<: *binary_common
Expand Down