Skip to content

Added eps in the __repr__ of FrozenBN #2852

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Oct 21, 2020
Merged

Added eps in the __repr__ of FrozenBN #2852

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
e2ca060
feat: Updated FrozenBN eps to align with BatchNorm
frgfm Oct 21, 2020
7333607
feat: Added eps to __repr__ of FrozenBN
frgfm Oct 21, 2020
56201f3
test: Updated unittest of __repr__ for FrozenBN
frgfm Oct 21, 2020
66429d2
test: Updated unittest for eps value in BN and FrozenBN
frgfm Oct 21, 2020
4d8f03f
fix: Revert FrozenBN eps value
frgfm Oct 21, 2020
d0dd78c
test: Revert test on eps alignment between FrozenBN and BN
frgfm Oct 21, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions test/test_ops.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -607,10 +607,11 @@ def script_func(x_, offset_, weight_, bias_, stride_, pad_, dilation_):
class FrozenBNTester(unittest.TestCase):
def test_frozenbatchnorm2d_repr(self):
num_features = 32
t = ops.misc.FrozenBatchNorm2d(num_features)
eps = 1e-5
t = ops.misc.FrozenBatchNorm2d(num_features, eps=eps)

# Check integrity of object __repr__ attribute
expected_string = f"FrozenBatchNorm2d({num_features})"
expected_string = f"FrozenBatchNorm2d({num_features}, eps={eps})"
self.assertEqual(t.__repr__(), expected_string)

def test_frozenbatchnorm2d_eps(self):
Expand Down
2 changes: 1 addition & 1 deletion torchvision/ops/misc.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -96,4 +96,4 @@ def forward(self, x: Tensor) -> Tensor:
return x * scale + bias

def __repr__(self) -> str:
return f"{self.__class__.__name__}({self.weight.shape[0]})"
return f"{self.__class__.__name__}({self.weight.shape[0]}, eps={self.eps})"