Deprecated F_t.center_crop, F_t.five_crop, F_t.ten_crop #2568
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updated docs - Put warning in the code - Updated tests
vfdev-5
added a commit
to Quansight/vision
that referenced
this pull request
Aug 10, 2020
- fixed bug with transforms using generated grid - remains *_crop, blocked by pytorch#2568 - TODO: test_adjustments
2 tasks
fmassa
approved these changes
Aug 11, 2020
| self.assertTrue(torch.equal(hflipped_img, hflipped_img_script)) | ||
|
|
||
| def test_crop(self): | ||
| script_crop = torch.jit.script(F_t.crop) |
There was a problem hiding this comment.
Do we want to change this to be F.crop ?
There was a problem hiding this comment.
Sounds good, I can change it in #2569
fmassa
added a commit
that referenced
this pull request
Aug 20, 2020
* Adapted almost all functional tensor tests on CPU/CUDA - fixed bug with transforms using generated grid - remains *_crop, blocked by #2568 - TODO: test_adjustments * Apply suggestions from code review Co-authored-by: Francisco Massa <[email protected]> * Fixed issues according to review * Split tests into two: cpu and cuda * Updated test_adjustments to run on CPU and CUDA Co-authored-by: Francisco Massa <[email protected]>
bryant1410
pushed a commit
to bryant1410/vision-1
that referenced
this pull request
Nov 22, 2020
- Updated docs - Put warning in the code - Updated tests
bryant1410
pushed a commit
to bryant1410/vision-1
that referenced
this pull request
Nov 22, 2020
* Adapted almost all functional tensor tests on CPU/CUDA - fixed bug with transforms using generated grid - remains *_crop, blocked by pytorch#2568 - TODO: test_adjustments * Apply suggestions from code review Co-authored-by: Francisco Massa <[email protected]> * Fixed issues according to review * Split tests into two: cpu and cuda * Updated test_adjustments to run on CPU and CUDA Co-authored-by: Francisco Massa <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Current implementation of
F_t.center_crop,F_t.five_crop,F_t.ten_cropare not used byF.*_cropmethods andF_t.five_crop,F_t.ten_cropseem to have a bug: https://github.com/pytorch/vision/pull/1615/files#diff-c0702298c1651f8c03d065692608f5dbR92 with indices 1 and 2.