Update torchvision ops in doc #2341
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fmassa
approved these changes
Jun 23, 2020
Member
fmassa
left a comment
fmassa
left a comment
There was a problem hiding this comment.
Thanks for the doc improvements!
Originally batched_nms was experimental, but I think we can promote them now.
Also, I just noted that we can update the docs to mention that all operators now support torchscript, can you send a follow-up PR fixing this?
Comment on lines
+24
to
+25
| .. autoclass:: MultiScaleRoIAlign | ||
| .. autoclass:: FeaturePyramidNetwork |
Member
There was a problem hiding this comment.
I was thinking that those two were still a bit experimental, but enough time has passed already so I think we can add those as well
| Those operators currently do not support TorchScript. | ||
|
|
||
|
|
||
| .. autofunction:: nms |
Member
There was a problem hiding this comment.
Additionally, can you send a new PR changing line 9, as now all operators support torchscript.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed in #1586 , the
deform_conv2d,PSPOIPoolwas not updated in Doc, so added in this PR.And, the operator
batched_nmsis useful in many cases, would it be considered to be added in this pull request?