ci: Automate uploading to correct upload channel #2204
Conversation
seemethere
force-pushed
the
torch_release_cycle_improvements
branch
from
d4813a4 to
b7caa89
Compare
|
fmassa
left a comment
fmassa
left a comment
There was a problem hiding this comment.
Generally looks good, but I have a question regarding CIRCLE_TAG
| command: | | ||
| our_upload_channel=nightly | ||
| # On tags upload to test instead | ||
| if [[ -n "${CIRCLE_TAG}" ]]; then |
There was a problem hiding this comment.
How does the CIRCLE_TAG works? Will we need to first make a release on GitHub (and commit the PR on the tag) so that the job running on the branch gets activated?
What if we need to run fixes on top of the tag, we will need to create new tags with the fixes?
There was a problem hiding this comment.
Yes it works exactly that way.
With the upstream pytorch/pytorch repository we've piloted this for the 1.5.0 release with pretty good success so I'm hoping to bring that same workflow to all of the downstream repositories.
|
Is there a way to automagically exclude autogenerated files from review? |
There isn't really, sometimes though with the auto-generated files the diff will be too large and they'll exclude themselves |
Automate switch to the test channel on tag and swapping out our BUILD_VERSION for the tag name on tag. Swapping BUILD_VERSION doesn't work on windows, but that will come in a follow up commit. Signed-off-by: Eli Uriegas <[email protected]>
seemethere
force-pushed
the
torch_release_cycle_improvements
branch
from
b7caa89 to
de949b3
Compare
4 participants
Automate switch to the test channel on tag and swapping out our
BUILD_VERSION for the tag name on tag.
Swapping BUILD_VERSION doesn't work on windows, but that will come in a
follow up commit.
cc @peterjc123, could you point me in the direction where the version is defined for windows?
Signed-off-by: Eli Uriegas [email protected]