Skip to content

Conversation

@carriesmi
Copy link
Contributor

removed word Image from DatasetFolder parameter discription

Copy link
Member

@fmassa fmassa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

There is a grammar error I think, can you address it?

target_transform (callable, optional): A function/transform that takes
in the target and transforms it.
is_valid_file (callable, optional): A function that takes path of an Image file
is_valid_file (callable, optional): A function that takes path of an file
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you replace this by

A function that takes path of a file

given that now you need to use a file?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done and remove some unwanted _

@codecov-io
Copy link

codecov-io commented Aug 30, 2019

Codecov Report

Merging #1284 into master will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1284      +/-   ##
==========================================
+ Coverage   65.57%   65.59%   +0.01%     
==========================================
  Files          74       74              
  Lines        5784     5784              
  Branches      884      884              
==========================================
+ Hits         3793     3794       +1     
+ Misses       1725     1724       -1     
  Partials      266      266
Impacted Files Coverage Δ
torchvision/datasets/folder.py 82.05% <ø> (ø) ⬆️
torchvision/transforms/transforms.py 80.94% <0%> (ø) ⬆️
torchvision/transforms/functional.py 71.38% <0%> (+0.28%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7c9bbf5...ca6a1db. Read the comment docs.

Copy link
Member

@fmassa fmassa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@fmassa fmassa merged commit 20a4a42 into pytorch:master Sep 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants