Skip to content

Conversation

@surgan12
Copy link
Contributor

@surgan12 surgan12 commented Jul 30, 2019

Fixes #1170

@surgan12 surgan12 changed the title flaky test improved test_randomresized_params fixes Jul 30, 2019
@fmassa fmassa closed this Jul 30, 2019
@fmassa fmassa reopened this Jul 30, 2019
@fmassa
Copy link
Member

fmassa commented Jul 30, 2019

(closed and reopened to rerun tests)

@surgan12
Copy link
Contributor Author

@fmassa , the tests are still failing.

@fmassa fmassa closed this Jul 31, 2019
@fmassa fmassa reopened this Jul 31, 2019
@fmassa
Copy link
Member

fmassa commented Jul 31, 2019

Let's see if they pass now

@surgan12
Copy link
Contributor Author

@fmassa , i think it is good to go now.

Copy link
Member

@fmassa fmassa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you explain the reasoning behind this change?

I think that a more robust fix would be to replace

log_ratio = (math.log(ratio[0]), math.log(ratio[1]))

with

log_ratio = (math.log(min(ratio)), math.log(max(ratio)))

@fmassa
Copy link
Member

fmassa commented Aug 30, 2019

My previous reasoning was wrong. I'm closing this in favor of #1282

Thanks @surgan12 for the original PR!

@fmassa fmassa closed this Aug 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

test_randomresized_params is flaky

2 participants