Skip to content

Enable symbol annotations for Windows #1081

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 3, 2019
Merged

Enable symbol annotations for Windows #1081

merged 1 commit into from
Jul 3, 2019

Conversation

@peterjc123
Copy link
Contributor

@peterjc123 peterjc123 commented Jul 3, 2019 •
edited
Loading

Fixes #1075

fmassa
fmassa approved these changes Jul 3, 2019
View reviewed changes
Copy link
Member

@fmassa fmassa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@fmassa fmassa merged commit 6c56029 into pytorch:master Jul 3, 2019
@peterjc123 peterjc123 deleted the win_define_fix branch July 4, 2019 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fmassa fmassa fmassa approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Build error on windows (error C2491)

2 participants

@peterjc123 @fmassa