Do we need the Docker CI job?

[pmeier]

The CircleCI config is finally getting quite scarce. One of the jobs we have not on our migration plan to GHA yet, is our Docker smoke test:

vision/.circleci/config.yml

Lines 261 to 271 in 300a909

	docker_build:
	triggers:
	- schedule:
	cron: "0 10 * * 0"
	filters:
	branches:
	only:
	- main
	jobs:
	- smoke_test_docker_image_build:
	context: org-member

vision/.circleci/config.yml

Lines 127 to 146 in 300a909

	smoke_test_docker_image_build:
	machine:
	image: ubuntu-2004:202104-01
	resource_class: large
	environment:
	image_name: torchvision/smoke_test
	steps:
	- checkout
	- designate_upload_channel
	- run:
	name: Build and push Docker image
	no_output_timeout: "1h"
	command: |
	set +x
	echo "${DOCKER_HUB_TOKEN}" | docker login --username "${DOCKER_HUB_USERNAME}" --password-stdin
	set -x
	cd .circleci/smoke_test/docker && docker build . -t ${image_name}:${CIRCLE_WORKFLOW_ID}
	docker tag ${image_name}:${CIRCLE_WORKFLOW_ID} ${image_name}:latest
	docker push ${image_name}:${CIRCLE_WORKFLOW_ID}
	docker push ${image_name}:latest

vision/.circleci/smoke_test/docker/Dockerfile

Lines 12 to 34 in 300a909

	FROM ubuntu:latest
	RUN apt-get -qq update && apt-get -qq -y install curl bzip2 libsox-fmt-all \
	&& curl -sSL https://repo.continuum.io/miniconda/Miniconda3-latest-Linux-x86_64.sh -o /tmp/miniconda.sh \
	&& bash /tmp/miniconda.sh -bfp /usr/local \
	&& rm -rf /tmp/miniconda.sh \
	&& conda install -y python=3 \
	&& conda update conda \
	&& apt-get -qq -y remove curl bzip2 \
	&& apt-get -qq -y autoremove \
	&& apt-get autoclean \
	&& rm -rf /var/lib/apt/lists/* /var/log/dpkg.log \
	&& conda clean --all --yes
	ENV PATH /opt/conda/bin:$PATH
	RUN conda create -y --name python3.7 python=3.7
	RUN conda create -y --name python3.8 python=3.8
	RUN conda create -y --name python3.9 python=3.9
	RUN conda create -y --name python3.10 python=3.10
	SHELL [ "/bin/bash", "-c" ]
	RUN echo "source /usr/local/etc/profile.d/conda.sh" >> ~/.bashrc
	CMD [ "/bin/bash"]

TBH, I didn't even know it was there. It runs once a week and I have never seen it fail for as long as I have been around. Not that I have checked, since there is no feedback mechanism to alert us of any failures.

Looking at the CircleCI logs, it seems the job is also net setup correctly, as it is not run and marked as unauthorized.

I guess this can go?

cc @seemethere

[pmeier]

Ok, I think I understand now. I was confused why this "smoke test" doesn't even install TorchVision and thus what its purpose actually is. Looking at #2437 that added it, is seems that this was never a smoke test, but built the image that other smoke tests were run on.

Since we have proper smoke tests for our wheel and conda builds on GHA already, there is no need to keep this.