Cmake Windows integration

[atalman]

The PR that address CMake integration fails on GPU builds #7417

Call stack:

Call Stack (most recent call first):
  C:/Jenkins/Miniconda3/envs/py39/Library/share/cmake-3.22/Modules/CMakeDetermineCompilerId.cmake:6 (CMAKE_DETERMINE_COMPILER_ID_BUILD)
  C:/Jenkins/Miniconda3/envs/py39/Library/share/cmake-3.22/Modules/CMakeDetermineCompilerId.cmake:59 (__determine_compiler_id_test)
  C:/Jenkins/Miniconda3/envs/py39/Library/share/cmake-3.22/Modules/CMakeDetermineCUDACompiler.cmake:298 (CMAKE_DETERMINE_COMPILER_ID)

[malfet]

Error stems somewhere from:
https://github.com/Kitware/CMake/blob/0bfd4f1ed68180d3912386fb53d559b2a9e84b1b/Modules/CMakeDetermineCompilerId.cmake#LL469C14-L469C44

Which expects environment variable to be defined here
https://github.com/Kitware/CMake/blob/0bfd4f1ed68180d3912386fb53d559b2a9e84b1b/Source/cmGlobalVisualStudio10Generator.cxx#L394
And if I understand https://github.com/Kitware/CMake/blob/0bfd4f1ed68180d3912386fb53d559b2a9e84b1b/Source/cmGlobalVisualStudio10Generator.cxx#L283 correctly, it's looking for extras\\visual_studio_integration\\MSBuildExtensions folder.
Which means, in this workflow one is trying to generate VisualStudio project, which depends on optional CUDA toolkit component, which is likely not installed in the AMI

[atalman]

Yes this is correct. The CUDA toolkit is on the path and just before the error, cuda is found:

-- Found CUDA: C:/Program Files/NVIDIA GPU Computing Toolkit/CUDA/v11.7 (found version "11.7") 

[pmeier]

We are copying some files from the extras\\visual_studio_integration\\MSBuildExtensions folder of the extracted CUDA toolkit to the VS folders:

vision/packaging/windows/internal/cuda_install.bat

Lines 130 to 137 in 689ff29

	echo Installing VS integration...
	rem It's for VS 2019
	if "%CUDA_VER_MAJOR%" == "10" (
	xcopy /Y "%SRC_DIR%\temp_build\cuda\CUDAVisualStudioIntegration\extras\visual_studio_integration\MSBuildExtensions\*.*" "C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\MSBuild\Microsoft\VC\v160\BuildCustomizations"
	)
	if "%CUDA_VER_MAJOR%" == "11" (
	xcopy /Y "%SRC_DIR%\temp_build\cuda\visual_studio_integration\CUDAVisualStudioIntegration\extras\visual_studio_integration\MSBuildExtensions\*.*" "C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\MSBuild\Microsoft\VC\v160\BuildCustomizations"
	)

So maybe we just need to copy this to the right path?

While debugging this, I didn't find these files on our image directly, but had to run the CUDA installation manually again. Meaning, if we actually need these files, we likely need to rebuild the AMI.

[atalman]

@pmeier , @malfet Ok looks like the issue is exactly that this step failing :

xcopy /Y "%SRC_DIR%\temp_build\cuda\visual_studio_integration\CUDAVisualStudioIntegration\extras\visual_studio_integration\MSBuildExtensions\*.*" "C:\Program Files (x86)\Microsoft Visual Studio\2019\Community\MSBuild\Microsoft\VC\v160\BuildCustomizations" 

The path is not correct should be:
C:\Program Files (x86)\Microsoft Visual Studio\2019\BuildTools\MSBuild\Microsoft\VC\v160\BuildCustomizations

[atalman]

This commit should fix the above issue with CUDA not found: 9baaf70