-
Notifications
You must be signed in to change notification settings - Fork 4.3k
fix confusion w.r.t. which model to serialize and use in cpp_export tutorial #609
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@brianjo would it be possible to merge a small update to this tutorial? @SethHWeidman gave it a try and, unfortunately, it wasn't as clear as we would've hoped 😢 |
|
Deploy preview for pytorch-tutorials-preview ready! Built with commit 06343d7 https://deploy-preview-609--pytorch-tutorials-preview.netlify.com |
|
Appreciate you making these changes @Krovatkin. Could I request one more change? In the line near the end of the tutorial: Could we change this to: Part of my confusion in going through this tutorial was that the Adding a note to this effect - that we are pushing a 4D Tensor through our model here, so this |
Arrgh, I thought |
|
I'll merge this after it rebases. Thanks! |
|
Hey @Krovatkin, don't mean to be a pest about this, but I meant the very last time we call
Could we change that line to:
Or Brian or I can change directly on Update: made the change. @brianjo I'm not 100% familiar with our Pull Request system, but making a change to a file on an existing PR like this shouldn't be an issue, right? |
|
@SethHWeidman ah, you meant the output of a CMake script. Nice catch! Thanks for the update! |
fix confusion w.r.t. which model to serialize and use in cpp_export tutorial
Addressing feedback we got from @SethHWeidman .
Mainly, making sure there's no confusion which serialized model should be loaded in a c++ app.