Skip to content

Update Super Resolution Tutorial to Use ONNXRuntime #559

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jul 25, 2019
Merged

Update Super Resolution Tutorial to Use ONNXRuntime #559

merged 7 commits into from
Jul 25, 2019

Conversation

@lara-hdr
Copy link
Contributor

@lara-hdr lara-hdr commented Jul 17, 2019

No description provided.

@netlify
Copy link

netlify bot commented Jul 17, 2019 •
edited
Loading

Deploy preview for pytorch-tutorials-preview ready!

Built with commit 4201327

https://deploy-preview-559--pytorch-tutorials-preview.netlify.com

houseroad
houseroad reviewed Jul 23, 2019
View reviewed changes
Copy link
Member

@houseroad houseroad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the ouptut size we use in this example, I saw the new generated output is much smaller than the original one.

Thanks for updating the tutorial, please also check the inline comments.

spandantiwari
spandantiwari reviewed Jul 23, 2019
View reviewed changes
lara-hdr
lara-hdr commented Jul 23, 2019
View reviewed changes
@lara-hdr
Copy link
Contributor Author

lara-hdr commented Jul 23, 2019

What is the ouptut size we use in this example, I saw the new generated output is much smaller than the original one.

The output size is actually bigger, it is 672x672 (the previous is 402x402).
I computed the output with torch_model and got the same size as well (672x672).

houseroad
houseroad reviewed Jul 23, 2019
View reviewed changes
@jspisak
Copy link
Contributor

jspisak commented Jul 24, 2019

@lara-hdr - thanks so much for pulling this update together!

@jspisak
Copy link
Contributor

jspisak commented Jul 24, 2019

cc @brianjo - please take a look as well before we merge prior to the v1.2 release. Thanks!!

houseroad
houseroad approved these changes Jul 24, 2019
View reviewed changes
Copy link
Member

@houseroad houseroad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@houseroad houseroad mentioned this pull request Jul 24, 2019
Closed
4 tasks
@brianjo
Copy link
Contributor

brianjo commented Jul 25, 2019

Thanks for your work on this @lara-hdr.

@brianjo brianjo merged commit a51999e into pytorch:master Jul 25, 2019
@jspisak jspisak mentioned this pull request Jul 26, 2019
Closed
rodrigo-techera pushed a commit to Experience-Monks/tutorials that referenced this pull request Nov 29, 2021
@brianjo
Merge pull request pytorch#559 from lara-hdr/lahaidar/ort_tutorial
a3e626b 
Update Super Resolution Tutorial to Use ONNXRuntime
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@spandantiwari spandantiwari spandantiwari left review comments

@houseroad houseroad houseroad approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@lara-hdr @jspisak @brianjo @spandantiwari @houseroad