[nn_tutorial.py] remove line var before line print(var)
#499
Conversation
I guess, the line `x_train, x_train.shape, y_train.min(), y_train.max()` was useful in notebook environment where its presence caused jupyter to display these variables. But there are `print` statements below this line printing the same variables. So I think it's better to omit this line as it does nothing and looks confusing.
|
Deploy preview for pytorch-tutorials-preview ready! Built with commit ec341ff https://deploy-preview-499--pytorch-tutorials-preview.netlify.app |
Oktosha
changed the title
var before line print(var)
|
Hi @Oktosha! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
|
Hi @Oktosha! Can you sign the CLA agreement so that I can merge the pull request? Thanks! |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
I guess, the line `x_train, x_train.shape, y_train.min(), y_train.max()` was useful in notebook environment where its presence caused jupyter to display these variables. But there are `print` statements below this line printing the same variables. So I think it's better to omit this line as it does nothing and looks confusing. Co-authored-by: Seth Weidman <[email protected]> Co-authored-by: holly1238 <[email protected]>
4 participants
It's really a typo-level fix. I suggest to remove the line
which comes right before the lines
It looks like the line I suggest to remove was used to make the notebook to display the variables. But there are print statements below that print the very same variables. So, if I get it right, the line I suggest to remove serves for nothing. That's why I suggest to remove it for clarity.