Wrap Tutorials/Gallery divs #1511
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for pytorch-tutorials-preview ready! Built with commit be38a39 https://deploy-preview-1511--pytorch-tutorials-preview.netlify.app |
9bow
added a commit
to PyTorchKorea/tutorials-kr
that referenced
this pull request
May 16, 2021
9bow
added a commit
to PyTorchKorea/tutorials-kr
that referenced
this pull request
May 16, 2021
rodrigo-techera
pushed a commit
to Experience-Monks/tutorials
that referenced
this pull request
Nov 29, 2021
Co-authored-by: Brandon Green <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR wraps tutorial cards in an
<a>tag to solve the issue of JS hijacking default on-click behavior.Issue: pytorch/pytorch_sphinx_theme#93
Screenshot to show card body wrapped by an
<a>tagNOTE
The cmd + click functionality in the Netlify preview will open a card in a new tab and also return an undefined page. PR #120 fixes this issue by removing the JS responsible.