Skip to content

Update ddp tutorial to tell user that TcpStore has been enabled on Windows platform #1321

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Feb 22, 2021
Merged

Update ddp tutorial to tell user that TcpStore has been enabled on Windows platform #1321

merged 5 commits into from
Feb 22, 2021

Conversation

@gunandrose4u
Copy link
Contributor

@gunandrose4u gunandrose4u commented Jan 28, 2021

No description provided.

@gunandrose4u
Copy link
Contributor Author

gunandrose4u commented Jan 28, 2021

@mrshenli , please help to review ddp_tutorial updates for enable TcpStore on Windows. Thank you!

@netlify
Copy link

netlify bot commented Jan 28, 2021 •
edited
Loading

Deploy preview for pytorch-tutorials-preview ready!

Built with commit 4039c3b

https://deploy-preview-1321--pytorch-tutorials-preview.netlify.app

mrshenli
mrshenli approved these changes Feb 3, 2021
View reviewed changes
Copy link
Contributor

@mrshenli mrshenli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

intermediate_source/ddp_tutorial.rst Outdated
Comment on lines 83 to 84
# Distributed package only covers collective communications with Gloo
# backend, FileStore and TcpStore on Windows platform.
Copy link
Contributor

@mrshenli mrshenli Feb 3, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: trying to make it more explicit

On Windows platform, the torch.distributed package only supports Gloo backend,
FileStore and TcpStore.

Copy link
Contributor Author

@gunandrose4u gunandrose4u Feb 3, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resolved

@mrshenli
Copy link
Contributor

mrshenli commented Feb 3, 2021

Hey @jlin27, the CI failure seem irrelevant to this PR. Shall we land?

Jan 28 06:48:44 Collecting torch (from -r /var/lib/jenkins/workspace/.jenkins/../requirements.txt (line 9))
Jan 28 06:48:44   Downloading https://files.pythonhosted.org/packages/90/4f/acf48b3a18a8f9223c6616647f0a011a5713a985336088d7c76f3a211374/torch-1.7.1-cp36-cp36m-manylinux1_x86_64.whl (776.8MB)
Jan 28 06:48:52 Exception:
Jan 28 06:48:52 Traceback (most recent call last):
Jan 28 06:48:52   File "/opt/conda/lib/python3.6/site-packages/pip/_vendor/urllib3/contrib/pyopenssl.py", line 294, in recv_into
Jan 28 06:48:52     return self.connection.recv_into(*args, **kwargs)
Jan 28 06:48:52   File "/opt/conda/lib/python3.6/site-packages/OpenSSL/SSL.py", line 1822, in recv_into
Jan 28 06:48:52     self._raise_ssl_error(self._ssl, result)
Jan 28 06:48:52   File "/opt/conda/lib/python3.6/site-packages/OpenSSL/SSL.py", line 1639, in _raise_ssl_error
Jan 28 06:48:52     raise SysCallError(errno, errorcode.get(errno))
Jan 28 06:48:52 OpenSSL.SSL.SysCallError: (104, 'ECONNRESET')
Jan 28 06:48:52 
Jan 28 06:48:52 During handling of the above exception, another exception occurred:

Base automatically changed from master to main February 16, 2021 19:33
Base automatically changed from main to master February 16, 2021 19:37
@malfet malfet merged commit a6ae79a into pytorch:master Feb 22, 2021
@gunandrose4u
Copy link
Contributor Author

gunandrose4u commented Feb 22, 2021

Thank you for merging the PR! @malfet, @mrshenli

gaoteng-git pushed a commit to gaoteng-git/tutorials that referenced this pull request Mar 2, 2021
@gunandrose4u @gaoteng-git
Update ddp tutorial to tell user that TcpStore has been enabled on Wi…
7b0fb39 
…ndows platform (pytorch#1321)

* Update tutorial to tell user that TcpStore has been enabled on Windows

* Resolve review comments
rodrigo-techera pushed a commit to Experience-Monks/tutorials that referenced this pull request Nov 29, 2021
@gunandrose4u
Update ddp tutorial to tell user that TcpStore has been enabled on Wi…
b3c6b9a 
…ndows platform (pytorch#1321)

* Update tutorial to tell user that TcpStore has been enabled on Windows

* Resolve review comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@malfet malfet malfet approved these changes

@mrshenli mrshenli mrshenli approved these changes

Assignees

No one assigned

Labels

cla signed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@gunandrose4u @mrshenli @malfet @facebook-github-bot