Added cache for incremental build. #1184
Conversation
|
Deploy preview for pytorch-tutorials-preview ready! Built with commit 17fb8da https://deploy-preview-1184--pytorch-tutorials-preview.netlify.app |
|
Fix for #1108 |
There was a problem hiding this comment.
This looks mostly okay, but wouldn't this only save the cache for the current PR / job?
Like, from my overview, it seems to me that the first runs would take exactly the same amount of time as it currently takes. Only subsequent runs would actually benefit from this cache.
Ii caches for master branch too. And yes, the first time run does not have cache to use and subsequent run benefit for the cache. |
|
Hi @v-jizhang! Thank you for your pull request. We require contributors to sign our Contributor License Agreement, and yours needs attention. You currently have a record in our system, but we do not have a signature on file. In order for us to review and merge your code, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
|
I'm thinking about merging this if we pass tests. Could reviewers chime in on it? |
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Facebook open source project. Thanks! |
* Added cache for incremental build. * Test cache * Added more content to cache * Added more content to cache * Test build cache Co-authored-by: v-jizhang <[email protected]> Co-authored-by: Brian Johnson <[email protected]> Co-authored-by: holly1238 <[email protected]>
) This reverts commit 03341a2.
7 participants
Added cache for incremental build.