Skip to content

Enable libUV for torchtrain #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 28, 2024
Merged

Enable libUV for torchtrain #98

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
35cec19
Enable libUV for torchtrain
Feb 28, 2024
9066b6c
add comment for the env variable
Feb 28, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions run_llama_train.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,9 @@

set -ex

# libUV is a scalable backend for TCPStore which is used in processGroup
# rendezvous. This is the recommended backend for distributed training.
export USE_LIBUV=1
Copy link
Collaborator

@wanchaol wanchaol Feb 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO we should at least add a comment why we are using libuv here

Copy link
Contributor Author

@gnadathur gnadathur Feb 28, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

TRAINER_DIR=${1:-/home/$USER/local/torchtrain}

# use envs as local overrides for convenience
Expand Down