Skip to content

Conversation

@tianyu-l
Copy link
Contributor

@tianyu-l tianyu-l commented Feb 27, 2024

Stack from ghstack (oldest at bottom):

Based on the feedbacks received, improve the TB section in README to reduce ambiguity. Also updated some outdated info.

tianyu-l added a commit that referenced this pull request Feb 27, 2024
ghstack-source-id: 396c782
Pull Request resolved: #96
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Meta Open Source bot. label Feb 27, 2024
@tianyu-l tianyu-l requested a review from wanchaol February 27, 2024 20:51
Copy link
Collaborator

@wanchaol wanchaol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one comment

README.md Outdated
```

3. then in the torchtrain repo
3. On the remote server, in the torchtrain repo, start the TensorBoard backend
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
3. On the remote server, in the torchtrain repo, start the TensorBoard backend
3. Inside the SSH tunnel that logged into the remote server, go to the torchtrain repo, and start the TensorBoard backend

Based on the feedbacks received, improve the TB section in README to reduce ambiguity. Also updated some outdated info.

[ghstack-poisoned]
tianyu-l added a commit that referenced this pull request Feb 27, 2024
ghstack-source-id: 7dc4a80
Pull Request resolved: #96
@tianyu-l tianyu-l merged commit 8f356fc into gh/tianyu-l/2/base Feb 27, 2024
tianyu-l added a commit that referenced this pull request Feb 27, 2024
ghstack-source-id: 7dc4a80
Pull Request resolved: #96
@tianyu-l tianyu-l deleted the gh/tianyu-l/2/head branch February 27, 2024 21:44
lessw2020 pushed a commit that referenced this pull request Apr 18, 2024
ghstack-source-id: 7dc4a80
Pull Request resolved: #96
philippguevorguian pushed a commit to YerevaNN/YNNtitan that referenced this pull request Aug 17, 2024
ghstack-source-id: 7dc4a80
Pull Request resolved: pytorch#96
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Meta Open Source bot.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants