Remove unneeded torchvision/audio deps #250
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
tianyu-l
reviewed
Apr 17, 2024
Contributor
tianyu-l
left a comment
tianyu-l
left a comment
There was a problem hiding this comment.
I think we need to keep torch and just remove torchvision and torchaudio?
| run: python -m pip install --upgrade pip | ||
| - name: Install dependencies | ||
| run: | | ||
| pip3 install --pre torch torchvision torchaudio --index-url https://download.pytorch.org/whl/nightly/cu121 |
Contributor
There was a problem hiding this comment.
I think we need to keep torch and just remove torchvision and torchaudio.
pip3 install --pre torch --index-url https://download.pytorch.org/whl/nightly/cu121
| - name: Install dependencies | ||
| run: | | ||
| pip3 install --pre torch torchvision torchaudio --index-url https://download.pytorch.org/whl/nightly/cu121 | ||
| python -m pip install -r requirements.txt |
Contributor
There was a problem hiding this comment.
ditto
pip3 install --pre torch --index-url https://download.pytorch.org/whl/nightly/cu121
tianyu-l
approved these changes
Apr 18, 2024
Contributor
tianyu-l
left a comment
tianyu-l
left a comment
There was a problem hiding this comment.
lgtm! thanks for the fix!
Collaborator
|
Can this PR be landed? |
Contributor
Author
|
sorry, landing now |
tianyu-l
pushed a commit
to tianyu-l/torchtitan_intern24
that referenced
this pull request
Aug 16, 2024
ghstack-source-id: dbd201a Pull Request resolved: pytorch#250
philippguevorguian
pushed a commit
to YerevaNN/YNNtitan
that referenced
this pull request
Aug 17, 2024
ghstack-source-id: dbd201a Pull Request resolved: pytorch#250
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):