Skip to content

Grammatical updates to GC logging #1737

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 22, 2025
Merged

Grammatical updates to GC logging #1737

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions torchtitan/tools/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,13 +55,13 @@ def run(self, step_count: int):
)
gc.collect()
elif step_count > 1 and step_count % self.gc_freq == 0:
self.collect("Performing periodical GC collection")
self.collect("Performing periodic GC collection")

@staticmethod
def collect(reason: str, generation: int = 1):
begin = time.monotonic()
gc.collect(generation)
logger.info("[GC] %s %.2f seconds", reason, time.monotonic() - begin)
logger.info("[GC] %s took %.2f seconds", reason, time.monotonic() - begin)


# hardcoded BF16 type peak flops for NVIDIA A100, H100, H200, B200 GPU and AMD MI250, MI300X, AMD MI325X and Intel PVC
Expand Down