Moving hash function to base planner class #3238
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D78996456 |
aliafzal
added a commit
to aliafzal/torchrec
that referenced
this pull request
Jul 25, 2025
Summary: Moving planner hash function into EmbeddingPlannerBase to give access all planner implementations access to this feature Reviewed By: aporialiao Differential Revision: D78996456
aliafzal
added a commit
to aliafzal/torchrec
that referenced
this pull request
Jul 29, 2025
Summary: Moving planner hash function into EmbeddingPlannerBase to give all planner implementations access to this feature Reviewed By: aporialiao Differential Revision: D78996456
aliafzal
added a commit
to aliafzal/torchrec
that referenced
this pull request
Jul 29, 2025
Summary: Moving planner hash function into EmbeddingPlannerBase to give all planner implementations access to this feature Reviewed By: aporialiao Differential Revision: D78996456
aliafzal
force-pushed
the
export-D78996456
branch
from
206320c to
7dc79b9
Compare
|
This pull request was exported from Phabricator. Differential Revision: D78996456 |
aliafzal
force-pushed
the
export-D78996456
branch
from
7dc79b9 to
ea86b18
Compare
|
This pull request was exported from Phabricator. Differential Revision: D78996456 |
aliafzal
force-pushed
the
export-D78996456
branch
from
ea86b18 to
8a1e7f8
Compare
aliafzal
added a commit
to aliafzal/torchrec
that referenced
this pull request
Jul 30, 2025
Summary: Moving planner hash function into EmbeddingPlannerBase to give all planner implementations access to this feature Reviewed By: aporialiao Differential Revision: D78996456
|
This pull request was exported from Phabricator. Differential Revision: D78996456 |
aliafzal
added a commit
to aliafzal/torchrec
that referenced
this pull request
Jul 30, 2025
Summary: Moving planner hash function into EmbeddingPlannerBase to give all planner implementations access to this feature Reviewed By: aporialiao Differential Revision: D78996456
aliafzal
added a commit
to aliafzal/torchrec
that referenced
this pull request
Aug 13, 2025
Summary: Moving planner hash function into EmbeddingPlannerBase to give all planner implementations access to this feature Reviewed By: aporialiao Differential Revision: D78996456
aliafzal
force-pushed
the
export-D78996456
branch
from
8a1e7f8 to
8b50d5d
Compare
|
This pull request was exported from Phabricator. Differential Revision: D78996456 |
aliafzal
added a commit
to aliafzal/torchrec
that referenced
this pull request
Aug 13, 2025
Summary: Moving planner hash function into EmbeddingPlannerBase to give all planner implementations access to this feature Reviewed By: aporialiao Differential Revision: D78996456
aliafzal
force-pushed
the
export-D78996456
branch
from
8b50d5d to
55606aa
Compare
aliafzal
added a commit
to aliafzal/torchrec
that referenced
this pull request
Aug 13, 2025
Summary: Moving planner hash function into EmbeddingPlannerBase to give all planner implementations access to this feature Reviewed By: aporialiao Differential Revision: D78996456
|
This pull request was exported from Phabricator. Differential Revision: D78996456 |
aliafzal
added a commit
to aliafzal/torchrec
that referenced
this pull request
Aug 13, 2025
Summary: Moving planner hash function into EmbeddingPlannerBase to give all planner implementations access to this feature Reviewed By: aporialiao Differential Revision: D78996456
Summary: Moving planner hash function into EmbeddingPlannerBase to give all planner implementations access to this feature Reviewed By: aporialiao Differential Revision: D78996456
aliafzal
force-pushed
the
export-D78996456
branch
from
55606aa to
c80bfab
Compare
|
This pull request was exported from Phabricator. Differential Revision: D78996456 |
aliafzal
added a commit
to aliafzal/torchrec
that referenced
this pull request
Aug 13, 2025
Summary: Moving planner hash function into EmbeddingPlannerBase to give all planner implementations access to this feature Reviewed By: aporialiao Differential Revision: D78996456
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: Moving planner hash function into EmbeddingPlannerBase to give access all planner implementations access to this feature
Differential Revision: D78996456