Skip to content
This repository was archived by the owner on Sep 10, 2025. It is now read-only.

Conversation

@Jack-Khuu
Copy link
Contributor

Some GH jobs that request MacOS are being given MPS machines, so the test cases attempt to MPS.
Issue is that MPS isn't available to via GH CI

This PR explicitly makes the tests use CPU

Tests that want mps/cuda should explicitly request for it

  • There is separate infrastructure that allows access

@pytorch-bot
Copy link

pytorch-bot bot commented Jul 30, 2024

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/torchchat/975

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 771bf8a with merge base d78710f (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Meta Open Source bot. label Jul 30, 2024
@Jack-Khuu Jack-Khuu requested a review from larryliu0820 July 30, 2024 19:08
@Jack-Khuu Jack-Khuu marked this pull request as ready for review July 30, 2024 19:08
@Jack-Khuu Jack-Khuu merged commit b2c3f26 into main Jul 30, 2024
Jack-Khuu added a commit that referenced this pull request Aug 2, 2024
* README: Add Headers to Troubleshooting Section

* Docs: Deduplicate quantization.md with the introduction of model_customization.md (#967)

* Update quantization.md

* Push precision into the customization and removed duplicate info from quantization

* Update docs README to call out vetted files

* Fix CI hang while running test-readme-mps-macos (#968)

* Explicitly use cpu when running GH machines; Tests that want mps/cuda should explicitly request for it (#975)

* README: Add Headers to Troubleshooting Section

---------

Co-authored-by: Nikita Shulga <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

CLA Signed This label is managed by the Meta Open Source bot.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants